Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make --enable-WP4-16-stacks the default for release 1.11.0 #557

Closed
antoninbas opened this issue Mar 3, 2018 · 0 comments
Closed

Make --enable-WP4-16-stacks the default for release 1.11.0 #557

antoninbas opened this issue Mar 3, 2018 · 0 comments
Milestone
Release 1.11.0

Comments

@antoninbas
Copy link
Member

No description provided.

@antoninbas antoninbas added this to the Release 1.11.0 milestone Mar 3, 2018
antoninbas added a commit that referenced this issue Mar 14, 2018
@antoninbas
Make P4_16 stack implementation the default
c3a2a1b 
As previously announced, we are making the P4_16-conformant
implementation for header stacks the default in prevision of the bmv2
1.11.0 release.

As a remainder, the new implementation differs from the old one in the
following ways: push_front and pop_front shift the entire stack (not
just until the next index), and pushed headers are marked as invalid
instead of valid.

The legacy implementation can be toggled by passing the
`--disable-WP4-16-stacks` flag to configure.

We recommend that exsiting P4_14 compilers inject an instruction to make
pushed header valid if they want to achieve a similar behavior as the
legacy implementation.

Fixes #557
@antoninbas antoninbas mentioned this issue Mar 14, 2018
Merged
antoninbas added a commit that referenced this issue Mar 16, 2018
@antoninbas
Make P4_16 stack implementation the default
9131ed9 
As previously announced, we are making the P4_16-conformant
implementation for header stacks the default in prevision of the bmv2
1.11.0 release.

As a remainder, the new implementation differs from the old one in the
following ways: push_front and pop_front shift the entire stack (not
just until the next index), and pushed headers are marked as invalid
instead of valid.

The legacy implementation can be toggled by passing the
`--disable-WP4-16-stacks` flag to configure.

We recommend that exsiting P4_14 compilers inject an instruction to make
pushed header valid if they want to achieve a similar behavior as the
legacy implementation.

Fixes #557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.11.0
Development

No branches or pull requests
1 participant
@antoninbas