Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make check: FAIL: test_queueing #900

Closed
Schweik7 opened this issue Jun 1, 2020 · 2 comments · Fixed by #903
Closed

make check: FAIL: test_queueing #900

Schweik7 opened this issue Jun 1, 2020 · 2 comments · Fixed by #903
Assignees

Comments

@Schweik7
Copy link

Schweik7 commented Jun 1, 2020

i install most of libs by using "apt install xxx-dev" ,not from source.And after "make check",only 1 test failed:test_queueing.
this is the result of "cat tests/test-suite.log":

...
FAIL: test_queueing

[==========] Running 6 tests from 5 test cases.
[----------] Global test environment set-up.
[----------] 1 test from QueueingTest/0, where TypeParam = bm::QueueingLogic<std::unique_ptr<int, std::default_delete >, WorkerMapper>
[ RUN ] QueueingTest/0.ProducerConsummer
[ OK ] QueueingTest/0.ProducerConsummer (110 ms)
[----------] 1 test from QueueingTest/0 (110 ms total)

[----------] 1 test from QueueingTest/1, where TypeParam = bm::QueueingLogicRL<std::unique_ptr<int, std::default_delete >, WorkerMapper>
[ RUN ] QueueingTest/1.ProducerConsummer
test_queueing.cpp:141: Failure
Expected: expected_queue_id
Which is: 2
To be equal to: queue_id
Which is: 0
...

How to fix it?

@antoninbas
Copy link
Member

I have also seen these tests fail on some machines. I'm planning to look into this in the near future, but in the meantime I think it is safe for you to just ignore the failing queueing tests.

@Schweik7
Copy link
Author

Schweik7 commented Jun 2, 2020

@antoninbas Thanks your watching

@antoninbas antoninbas self-assigned this Jun 2, 2020
antoninbas added a commit that referenced this issue Jun 2, 2020
C++ clocks can return the same value in consecutive calls, which was
causing potential reordering in the queueing logic, in particular for
rate-limited queues when the pps rate was set to 0.

This was causing some unit tests to fail.

Fixes #900
antoninbas added a commit that referenced this issue Jun 2, 2020
C++ clocks can return the same value in consecutive calls, which was
causing potential reordering in the queueing logic, in particular for
rate-limited queues when the pps rate was set to 0.

This was causing some unit tests to fail.

Fixes #900
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants