Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1243. #1244

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Fix #1243. #1244

merged 4 commits into from
Apr 17, 2024

Conversation

matthewtlam
Copy link
Contributor

Fix race conditions when passing a BMv2 JSON Config into the command-line arguments when initializing SimpleSwitch.

smolkaj
smolkaj approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@smolkaj smolkaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

antoninbas
antoninbas reviewed Apr 17, 2024
View reviewed changes
src/bm_sim/switch.cpp Outdated Show resolved Hide resolved
@antoninbas antoninbas merged commit c37ec2d into p4lang:main Apr 17, 2024
7 checks passed
@matthewtlam matthewtlam deleted the patch-1 branch April 17, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoninbas antoninbas antoninbas approved these changes

@smolkaj smolkaj smolkaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewtlam @antoninbas @smolkaj