Fix mc_dump CLI command for SimplePre type #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command implementation was correct for SimplePreLAG but not for SimplePre, as it assumed the existence of LAG entries in the JSON returned by the switch. This addresses issue #342.
antoninbas
added a commit
that referenced
this pull request
Apr 27, 2017
The command implementation was correct for SimplePreLAG but not for SimplePre, as it assumed the existence of LAG entries in the JSON returned by the switch. This addresses issue #342.
Codecov Report
@@ Coverage Diff @@
## master #343 +/- ##
=======================================
Coverage 76.44% 76.44%
=======================================
Files 108 108
Lines 8607 8607
=======================================
Hits 6580 6580
Misses 2027 2027Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command implementation was correct for SimplePreLAG but not for
SimplePre, as it assumed the existence of LAG entries in the JSON
returned by the switch.
This addresses issue #342.