Do not use Packet::ingress_length in parser for PacketTooShort #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verbose PR because of new test, but really the actual change is quite small |
This may not be appropriate for architectures with multiple parsers (e.g. egress parser in PSA). This commit also ensures that ingress_length is updated properly for recirculated packets in simple_switch. Fixes #626
antoninbas
force-pushed
the
antonin/do-not-use-ingress-length-in-parser-to-check-if-enough-bytes-left
branch
from
3d00f30 to
530f405
Compare
Codecov Report
@@ Coverage Diff @@
## master #627 +/- ##
=========================================
+ Coverage 76.23% 76.4% +0.17%
=========================================
Files 110 110
Lines 9252 9252
=========================================
+ Hits 7053 7069 +16
+ Misses 2199 2183 -16
Continue to review full report at Codecov.
|
…r-to-check-if-enough-bytes-left
antoninbas
deleted the
antonin/do-not-use-ingress-length-in-parser-to-check-if-enough-bytes-left
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may not be appropriate for architectures with multiple parsers
(e.g. egress parser in PSA).
This commit also ensures that ingress_length is updated properly for
recirculated packets in simple_switch.
Fixes #626