Fix type deduction for expressions when importing JSON #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent fix for a separate issue (#888) exposed a separate bug: the type of expressions for which the top-level operator was "access_field" was not deduced properly (set to UNKNOWN instead of DATA), which caused bmv2 to assert when building the Action object. The same issue existed for "access_union_header", which is an operator introduced more recently (and possibly not used by p4c yet). Fixes #889
antoninbas
force-pushed
the
antonin/fix-type-deduction-for-expressions-in-json-importer
branch
from
e2f46e4 to
820bb44
Compare
antoninbas
deleted the
antonin/fix-type-deduction-for-expressions-in-json-importer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent fix for a separate issue
(#888) exposed a separate
bug: the type of expressions for which the top-level operator was
"access_field" was not deduced properly (set to UNKNOWN instead of
DATA), which caused bmv2 to assert when building the Action object.
The same issue existed for "access_union_header", which is an operator
introduced more recently (and possibly not used by p4c yet).
Fixes #889