Ensure that bmv2 targets are notified in case of config swap #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some case, the do_swap() call in simple_switch never returned 0 (because the swap was performed independently of the target), which meant that the with_queueing_metadata flag was not updated. This created an issue in the following specific scenario: * simple_switch is started with a JSON config that does not include queueing metadata fields * a JSON config swap is performed (using the runtime_CLI or P4Runtime, in the case of simple_switch_grpc), and the new config includes all queueing metadata fields * queueing metadata fields still show as 0 for all subsequent traffic To fix this, we get rid of the assumption that targets are in charge of calling do_swap() themselves, which must data back to when Packet instantiation was not guarded by a lock (thus requiring the collaboration of targets to ensure no new Packets were created as the swap if being performed). From now targets are notified using the swap_notify_() virtual method, which targets can override. Fixes #905
Codecov Report
@@ Coverage Diff @@
## master #906 +/- ##
=======================================
Coverage 74.32% 74.32%
=======================================
Files 115 115
Lines 10243 10247 +4
=======================================
+ Hits 7613 7616 +3
- Misses 2630 2631 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some case, the do_swap() call in simple_switch never returned 0
(because the swap was performed independently of the target), which
meant that the with_queueing_metadata flag was not updated.
This created an issue in the following specific scenario:
queueing metadata fields
in the case of simple_switch_grpc), and the new config includes all
queueing metadata fields
To fix this, we get rid of the assumption that targets are in charge of
calling do_swap() themselves, which must data back to when Packet
instantiation was not guarded by a lock (thus requiring the
collaboration of targets to ensure no new Packets were created as the
swap if being performed).
From now targets are notified using the swap_notify_() virtual method,
which targets can override.
Fixes #905