Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only suppress warnings in Vite dev mode and on client #82

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

myieye
Copy link

@myieye myieye commented Nov 28, 2023

We can't use this package unless this fix gets merged.

As I commented, suppressWarnings currently kills our node server, which is pretty wild, because it only gets "uninstrumented" on the client, so the console.warn call stack just grows and grows.

This is an improvement to the currently open PR #63.

The warnings are only logged in dev mode, so we can leave console.warn alone if we know that we're not in dev mode.
And we certainly don't want to touch globals in node/on the server.

I did my best to determine dev mode and client without assuming we're running in a Vite app.
If the code is not running in a Vite app, then we can't detect dev mode, so it will behave the same in the browser as it did before.
Except that I made the filter a bit smarter, so that it should only suppress warnings that are actually caused by markdown renderers.

@jstjoe
Copy link

jstjoe commented Nov 14, 2024

@pablo-abc thank you for approving this but it looks like it still needs to be merged? Could you do that, or add someone else as maintainer? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants