Fix boundary construction in GS.Bands
#253
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #252
The issue was in the construction of orbsleft and orbsright
LatticeSlice
s, which wrongly assumed that the sites coupled to a cell to the left (right) of the boundary spanned a single cell. TheseLatticeSlice
s are used to compute the G0 components that, combined, implement the boundary condition.Note: the
GS.Bands
solver still allocates too much, specially with boundaries. There is probably still some low-hanging fruit here.