use grave accents ` to allow any sample name for plot_scatter #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In
plot_scatter
,aes_string
fromggplot2
is used to take the log of the normalized counts for the scatter plot using the sample name as an expression. However, sample names that would cause a syntax error (e.g. using hyphens, which are interpreted as minus signs) cause an error unless the grave accent ' ` ' is used (this is the source of the error in #89).I'm not sure if there is another case where this proposed code would break when the original wouldn't (maybe check to make sure the sample names exist in the
sample_to_covariates
table?), but here is the proposed solution.Best,
Warren