Update to docker setup procedures #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameshiebert
approved these changes
May 26, 2017
| @@ -59,13 +59,46 @@ You can lint all files `npm run lint`, or a specific file `npm run lint:glob <fi | |||
|
|
|||
| Use the `git/hooks/pre-commit-eslint` (and install into your .git/hooks directory) to abort a commit if any staged `*.js` files fail linting (warnings OK). | |||
|
|
|||
| If you *realy* want to skip the linting during a commit, you can always run `git commit --no-verify`. However, this is not recommended. | |||
| If you *really* want to skip the linting during a commit, you can always run `git commit --no-verify`. However, this is not recommended. | |||
There was a problem hiding this comment.
Bah, thanks. Good catch :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last month, webpack was updated to patch a security vulnerability involving DNS rebinding. Added directions on how to configure webpack to accept requests addressed to the docker server's address.