fix: Inserting multiple small batches now works, even if the second b…

…atch triggers rebinding the buffer due to element size. Previously in this scenario not all values already inserted were correctly copied into the new buffer. This caused strings to be replaced with `null` bytes.
pacman82 · Dec 9, 2024 · e9f807b · e9f807b
1 parent 471bd54
commit e9f807b
Show file tree

Hide file tree

Showing 2 changed files with 65 additions and 67 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/tests/test_arrow_odbc.py b/tests/test_arrow_odbc.py
@@ -769,8 +769,6 @@ def iter_record_batches():
     assert "a\n1\n2\n3\n1\n2\n3\n" == actual.decode("utf8")
 
 
-@pytest.mark.xfail(reason="We do not know why this fails yet, maybe the second batch overwrites "
-                   "values for the first one. We'll try to reproduce it upstream in arrow-odbc")
 def test_insert_multiple_small_batches():
     """
     Insert multiple batches into the database, using one roundtrip.
@@ -934,7 +932,6 @@ def test_into_pyarrow_record_batch_reader_transfers_ownership():
         next(iter(arrow_reader))
 
 
-@pytest.mark.xfail(reason="This likely fails for the same reason as test_multiple_small_batches")
 def test_chunked_arrays_of_variable_length_strings():
     """
     See issue: <https://github.com/pacman82/arrow-odbc-py/issues/115>