chore: dont pass provider name if pact broker env vars set and using …

…dir source
pact-foundation · Nov 14, 2024 · 0579029 · 0579029
1 parent fb8e774
commit 0579029
Show file tree

Hide file tree

Showing 18 changed files with 131 additions and 114 deletions.
diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml
@@ -24,7 +24,7 @@ jobs:
       fail-fast: false
       matrix:
         node-version: [16, 18, 20, 22]
-        os: [macos-14, macos-12, ubuntu-latest, windows-latest]
+        os: [macos-14, macos-13, ubuntu-latest, windows-latest]
         docker: [false]
         alpine: [false]
         include:

diff --git a/examples/e2e/package-lock.json b/examples/e2e/package-lock.json
diff --git a/examples/graphql/package-lock.json b/examples/graphql/package-lock.json
diff --git a/examples/jest/package-lock.json b/examples/jest/package-lock.json
diff --git a/examples/messages/package-lock.json b/examples/messages/package-lock.json
diff --git a/examples/mocha/package-lock.json b/examples/mocha/package-lock.json
diff --git a/examples/serverless/package-lock.json b/examples/serverless/package-lock.json
diff --git a/examples/typescript/package-lock.json b/examples/typescript/package-lock.json
diff --git a/examples/v3/e2e/package-lock.json b/examples/v3/e2e/package-lock.json
diff --git a/examples/v3/provider-state-injected/package-lock.json b/examples/v3/provider-state-injected/package-lock.json
diff --git a/examples/v3/provider-state-injected/provider/account-service.test.js b/examples/v3/provider-state-injected/provider/account-service.test.js
@@ -18,7 +18,13 @@ describe('Account Service', () => {
 
   it('validates the expectations of Transaction Service', () => {
     let opts = {
-      provider: 'Account Service',
+      // if the provider name is set, and we have PACT_BROKER_BASE_URL plus env var creds set
+      // it will automatically attempt to retrieve from a pact broker via the default consumer version selectors.
+      // if we are verifying a pact directory source, we do not need to add the provider name
+      // as it is inferred from the pact file.
+      // this doesn't feel like desirable behavior (we should only verify one source at a time!)
+      // see https://github.com/pact-foundation/pact-reference/issues/250
+      // provider: 'Account Service',
       providerBaseUrl: 'http://localhost:8081',
       logLevel: LOG_LEVEL,
       stateHandlers: {