Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: HeaderFirstLevel's actions prop refactoring #391

Merged
merged 3 commits into from
Feb 5, 2025
Merged

refactor: HeaderFirstLevel's actions prop refactoring #391

merged 3 commits into from
Feb 5, 2025
+96 −72

Conversation

mastro993
Copy link
Contributor

Short description

This PR refactors HeaderFirstLevel's actions props with a dynamic type which allows to configure 0 to 3 actions.

List of changes proposed in this pull request

  • Replaced firstAction, secondAction and thirdAction with actions

How to test

Run the example app and go to the Header First Level page, test the header with different action configurations

@mastro993 mastro993 requested review from dmnplb and a team as code owners February 4, 2025 14:10
LeleDallas
LeleDallas approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@LeleDallas LeleDallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's exactly what I was suggesting here!

@mastro993 mastro993 merged commit 48143cd into 5.x Feb 5, 2025
6 checks passed
@mastro993 mastro993 deleted the refactor-header-first-level-actions-props branch February 5, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmnplb dmnplb dmnplb approved these changes

@LeleDallas LeleDallas LeleDallas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mastro993 @dmnplb @LeleDallas