Reverse DNS info when accepting socket connection without reflection #542
+265
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wi11dey
force-pushed
the
wdey/reverse-dns-without-reflection
branch
2 times, most recently
from
911f458
to
dccb0f5
Compare
wi11dey
force-pushed
the
wdey/reverse-dns-without-reflection
branch
from
dccb0f5
to
b3e0903
Compare
wi11dey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#540 without reflection and without doing extra DNS lookups (
getByAddressdoesn't do any lookups and is how Guava InetAddresses create InetAddresses without external calls)