writePredictedSpeculativeRetryPerformanceMetrics computes extra replica snapshot once #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlosna
force-pushed
the
davids/endpoint-snitch-metrics
branch
6 times, most recently
from
da116f3
to
b014b22
Compare
schlosna
force-pushed
the
davids/endpoint-snitch-metrics
branch
from
b014b22
to
e39cff9
Compare
|
lgtm, cutting rc to smoke test |
rhuffy
reviewed
Oct 28, 2024
Comment on lines
26
to
27
| import com.codahale.metrics.Snapshot; | ||
| import org.apache.cassandra.db.ColumnFamily; |
There was a problem hiding this comment.
Will update.
Is there a trick to getting this repo to play nicely with IntelliJ to autofix imports? I assume we don't want to apply the Palantir-java-format as Cassandra has a very different source style and backports would be much more difficult.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing some JFRs,
AbstractReadExecutor.writePredictedSpeculativeRetryPerformanceMetrics()andPredictedSpeculativeRetryPerformanceMetrics.maybeWriteMetrics(ColumnFamilyStore cfs, Collection<Long> latencies, Optional<Snapshot> extraReplicaSnapshot)pop up with heavy allocations that we can reduce by computing the extra replica snapshot once perwritePredictedSpeculativeRetryPerformanceMetricsinvocation