Write-ahead log dry run #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wi11dey
force-pushed
the
wdey/wal-dry-run
branch
from
91a4e10 to
0f4213d
Compare
wi11dey
force-pushed
the
wdey/wal-dry-run
branch
from
0f4213d to
cd1fdb9
Compare
zpear
reviewed
Oct 25, 2024
zpear
reviewed
Oct 25, 2024
src/java/com/palantir/cassandra/db/IColumnFamilyStoreValidator.java
Outdated
Show resolved
Hide resolved
zpear
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create the interface for the write-ahead log and call it at the right place (after a successful transaction). This PR does not expect the wal to be used and will continue closing refs/deleting inputs as usual (not blocking on a successful wal append) and cannot benefit from what the wal fixes. #557 will actually block on deletions until a successful wal append). This pr is only for dry-running the wal system and logging