Fix effective ownership in Nodetool Status and Ring #609
Conversation
| if (Schema.instance.getKeyspaceInstance(SystemPalantir.NAME) != null) | ||
| { | ||
| keyspace = SystemPalantir.NAME; | ||
| } |
There was a problem hiding this comment.
Instead of modifying it here (I feel it might be confusing if we use this functions in other pieces of the code), wanna add to theStatus class instead: ownerships = probe.effectiveOwnership(keyspace != null ? keyspace: SystemPalantir.NAME); and add a small comment on why we are doing this.
There was a problem hiding this comment.
I think this is the correct place for this logic because this method already contains logic to auto resolve a keyspace if none is provided
There was a problem hiding this comment.
Also, adding the system_palantir keyspace name as the argument to effectiveOwnership isn't great because then the method would throw in the case that system_palantir is not present, whereas in my patch it would instead fall back to the existing behavior.
|
|
||
| package com.palantir.cassandra.db; | ||
|
|
||
| final public class SystemPalantir |
Nodetool Status and Ring can display effective ownership information if a keyspace is provided, or if the non-system keyspaces all use the same replication strategy.
In our case, we can assume that the
system_palantirkeyspace is always present, and use its replication strategy by default, if present.