Removing Feature.AD_HOC_FORMATTING from PalantirJavaFormatFormattingService

[crogoz]

Before this PR

In #1078 we switched to the new Formatting APIs following google-java-format's commit: google/google-java-format@84b2c9a
However, this broke the Intelij generation code - see:

new generated code after extracting code:

expected code after extracting code:

After this PR

Removing Feature.AD_HOC_FORMATTING from PalantirJavaFormatFormattingService . The flag was remoced from google-java-format as well in a later PR: google/google-java-format@25ce685

==COMMIT_MSG==
Remove AD_HOC_FORMATTING
==COMMIT_MSG==

Possible downsides?

Fixes #1080

[changelog-app]

Generate changelog in changelog/@unreleased

What do the change types mean?

• feature: A new feature of the service.
• improvement: An incremental improvement in the functionality or operation of the service.
• fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
• break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
  and external consumers of the service's API (e.g. customer-written software or integrations).
• deprecation: Advertises the intention to remove service functionality without any change to the
  operation of the service itself.
• manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
  performing database surgery, ...) at the time of upgrade for it to succeed.
• migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

• ❗The break and manual task changelog types will result in a major release!
• 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
• ✨ All others will result in a minor version release.

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

Fixes bug where generated code or automated refactoring is formatted incorrectly by removing AD_HOC_FORMATTING

Check the box to generate changelog(s)

• Generate changelog entry

[CRogers]

Probably best to describe the change in terms of what the user cares about - I'd say something like "fixes bug where generated code or automated refactoring is formatted incorrectly by removing AD_HOC_FORMATTING"

[CRogers]

👍🏻

[svc-autorelease]

Released 2.46.0