Fix issue where formatter is not always enabled on save in intellij #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
CRogers
commented
Jul 30, 2024
|
|
||
| def myAllFileTypesSelectedAlreadySet = matchChild(onSaveOptions, 'option', [name: 'myAllFileTypesSelected']) | ||
| .map { Boolean.parseBoolean(it.attribute('value')) } | ||
| .orElse(true) |
There was a problem hiding this comment.
This is the crux of the bug. If myAllFileTypesSelected did not already exist, we would think it is already set to true and make no further changes, despite the default being false.
…led' of github.com:palantir/palantir-java-format into callumr/fix-issue-where-formatter-is-sometimes-not-enabled
CRogers
commented
Jul 30, 2024
| @@ -183,8 +177,7 @@ class ConfigureJavaFormatterXmlTest extends Specification { | |||
| def node = new XmlParser().parseText """ | |||
| <root> | |||
| <component name="${action}OnSaveOptions"> | |||
| <option name="myRunOnSave" value="true"/> | |||
| <!-- if myAllFileTypesSelected does not exist, it defaults to true --> | |||
|
👍 |
bulldozer-bot
bot
deleted the
callumr/fix-issue-where-formatter-is-sometimes-not-enabled
branch
|
Released 2.48.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
We've had sporadic reports of the formatter not being enabled on save in intellij. I ran into this yesterday and today.
After this PR
==COMMIT_MSG==
The formatter should now always been enabled on save in intellij.
==COMMIT_MSG==
Possible downsides?