Helpful Remediation in Known Error Situation #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarcaur
commented
Aug 13, 2024
| @@ -139,13 +139,20 @@ private static Path getJdkPath(Project project) { | |||
| .map(Path::of) | |||
| .map(sdkHome -> sdkHome.resolve("bin").resolve("java" + (SystemInfo.isWindows ? ".exe" : ""))) | |||
| .filter(Files::exists) | |||
| .orElseThrow(() -> new IllegalStateException("Could not determine jdk path for project " + project)); | |||
| .orElseThrow(() -> | |||
| new IllegalStateException("Could not determine JDK path for project: " + project.getName())); | |||
There was a problem hiding this comment.
Printing the project directly creates error messages like so:
Could not determine jdk version for project Project(name=product, containerState=COMPONENT_CREATED, componentStore=/path/to/product)
Which feels slightly leaky and generally not that useful.
bmarcaur
force-pushed
the
bmarcaurele/helpful-error-with-empty-sdk
branch
from
c542ca7 to
00cc924
Compare
bmarcaur
force-pushed
the
bmarcaurele/helpful-error-with-empty-sdk
branch
from
00cc924 to
f674ea9
Compare
CRogers
approved these changes
Aug 14, 2024
|
Released 2.50.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helped someone debug this locally. Figured adding these "docs" inline might save someone grief in the future.