Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for translation lint where punctuation and HTML entities are side by side #142

Merged
merged 1 commit into from
Feb 13, 2018
Merged

Fixes for translation lint where punctuation and HTML entities are side by side #142

merged 1 commit into from
Feb 13, 2018

Conversation

praxxis
Copy link
Contributor

@praxxis praxxis commented Feb 13, 2018 •
edited
Loading

This case came up running lint across our larger code base, where strings like {var1}: {var2} were incorrectly flagged when both punctuation and HTML entities were allowed.

Fixes for translation lint where punctuation and HTML entities are si…
aa4b1b8 
…de by side

This case came up running lint across our larger code base, where strings like "{var1}: {var2}" were incorrectly flagged when both punctuation and HTML entities were allowed.
adidahiya
adidahiya approved these changes Feb 13, 2018
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@adidahiya adidahiya merged commit 1c2f7fc into palantir:master Feb 13, 2018
@praxxis praxxis deleted the translation-lint-fixes branch February 13, 2018 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@praxxis @adidahiya