Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule prohibiting use of object and array literals in props #176

Closed
wants to merge 1 commit into from

Conversation

smoogly
Copy link

@smoogly smoogly commented Aug 7, 2018

By analogy to jsx-no-lambda and for same reasons. Closes #89.

By analogy to `jsx-no-lambda` and for same reasons. Closes palantir#89.
@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint-react, @smoogly! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@smoogly
Copy link
Author

smoogly commented Aug 7, 2018

I'm not signing the CLA. You're free to do what you like to this PR.

@johnwiseheart
Copy link

Closing this out as unfortunately without signing the CLA we are unable to merge this PR. Feel free to reopen it if you change your mind.

@smoogly
Copy link
Author

smoogly commented Aug 10, 2018

Did your policy change in the last two months?

#168 (comment)

@johnwiseheart
Copy link

I did not approve that PR - not sure what the policy was at that point but as far as I am aware this is the policy now. Not sure what your reasoning is for not signing the CLA, but it is no different to many other companies that manage open source software (Microsoft has a CLA on TypeScript itself, as an example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants