Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto fixer for jsx-space-before-trailing-slash #182

Merged

Conversation

heatherbooker
Copy link
Contributor

Hi,

This PR adds an auto fixer for the jsxSpaceBeforeTrailingSlash rule, along with a test and readme update.

The auto-fix uses appendText to add a single space before offending closing tags.

Let me know if it's missing anything! Shoutout to @zapo for co-driving to do this! 🙌

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint-react, @heatherbooker! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@heatherbooker
Copy link
Contributor Author

heatherbooker commented Oct 12, 2018

I signed the contributor's agreement but it seems it might not recognize it because the main email for my account is what the system used on the contract, but this commit is associated with a different email address (also on this account). 🤔

Fixed it!

@heatherbooker heatherbooker force-pushed the space-before-trailing-slash-fixer branch from 32b1b5d to 474d72b Compare November 8, 2018 23:01
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks @heatherbooker

@adidahiya adidahiya added the Formatting rule Relates to a rule which enforces code formatting and likely overlaps with prettier label Mar 12, 2019
@adidahiya adidahiya merged commit 9d9a299 into palantir:master Mar 12, 2019
@adidahiya adidahiya added this to the 3.7.0 milestone Mar 12, 2019
@heatherbooker heatherbooker deleted the space-before-trailing-slash-fixer branch March 13, 2019 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Formatting rule Relates to a rule which enforces code formatting and likely overlaps with prettier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants