Fix jsx-wrap-multiline rule for closing parenthesis

[mpsijm]

There was a bug in this rule: having the opening parenthesis on a new line before the opening tag, but the closing parenthesis on the same line as the closing tag, would not trigger this rule.
This was caused by the fact that the index variable (as calculated by siblings.indexOf) was equal to -1 in some cases.
The index is now calculated by checking just the pos and end fields of a node, instead of the default object equality that indexOf uses.

With this change, the check that tested whether the node started with a newline is no longer needed (and with it, also the prevTokenKind variable is no longer needed).

Also, two tests have been added:

• A multiline JSX component with the closing parenthesis on a new line, but the opening parenthisis on the same line
• A multiline JSX component with the opening parenthesis on a new line, but the closing parenthisis on the same line

[palantirtech]

Thanks for your interest in palantir/tslint-react, @mpsijm! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

[adidahiya]

nice, thanks @mpsijm

[magic-akari]

Hello.
Is it expected behavior ?

const Test: React.FC = () => {
    return ReactDOM.createPortal(
        <details>
            <summary>test</summary>
            <div>
                Lorem ipsum dolor sit amet consectetur adipisicing elit. Fugiat numquam aliquid et cum quis consequatur
                commodi aliquam iure optio, ipsam voluptatum iste libero quaerat quia. Quos cupiditate eaque neque odio!
            </div>
        </details>,
        document.querySelector("#test"),
    );
};

ERROR: src/test.tsx:3:9 - Multiline JSX elements must be wrapped in parentheses

[mpsijm]

@magic-akari I'd say yes, this is expected. The <details>...</details> element is not wrapped in parentheses. The </details> tag is followed by a comma and a call to querySelector.

[magic-akari]

Thank you for your reply.

The parentheses I added will be erased by the prettier. And I think the parentheses are unnecessary in this case. I prefer the rule of prettier.

Since this is the expected behavior, I have no choice but to disable this rule.

[mpsijm]

Ah, you did not yet say that there is a conflict between the pretty-printer and the linter.
That does sound like a problem, maybe you can open a new issue describing your situation?

[adidahiya]

prettier will often conflict with tslint & tslint-react's formatting rules. no need to open a new issue -- my recommendation is to stop using tslint & tslint-react's formatting rules and use prettier instead. the former will not be maintained in the future. see #210