Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Used bang in file-header #3741

Merged
merged 1 commit into from
Apr 9, 2018
Merged

Used bang in file-header #3741

merged 1 commit into from
Apr 9, 2018

Conversation

JoshuaKGoldberg
Copy link
Contributor

PR checklist

Overview of change:

Adds the ! to indicate to TypeScript that this should come before auto-added inserts.

CHANGELOG.md entry:

[enhancement] Added ! character to file-header auto-fixes.

@johnwiseheart
Copy link
Contributor

Hi @JoshuaKGoldberg, not sure whats happening with these tests - would you mind re-running them?

@JoshuaKGoldberg
Copy link
Contributor Author

@johnwiseheart I don't know how :( but looks like you restarted them?

@johnwiseheart
Copy link
Contributor

Hmm strange. Seems like they've passed but just not made its way back to github. We can merge this in.

@johnwiseheart johnwiseheart merged commit c89e0a7 into palantir:master Apr 9, 2018
@JoshuaKGoldberg JoshuaKGoldberg deleted the file-header-BANG branch April 9, 2018 23:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

file-header should create a /*! comment, not just /*
2 participants