This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 889
Address 3180: Rule file-header should have an option to allow // comments #4560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
suggested changes
Mar 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation details LGTM, just waiting on the options object.
JoshuaKGoldberg
previously requested changes
Mar 10, 2019
adidahiya
suggested changes
Mar 12, 2019
rrogowski
changed the title
Address 3810: Rule file-header should have an option to allow // comments
Address 3180: Rule file-header should have an option to allow // comments
Mar 19, 2019
@adidahiya @JoshuaKGoldberg ready for second review. |
adidahiya
suggested changes
Mar 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allow-single-line-comments
test/rules/file-header/good-allow-single-line-comments/tslint.json
Outdated
Show resolved
Hide resolved
@adidahiya Thanks for your comments. They have been addressed. Ready for another pass. |
adidahiya
approved these changes
Mar 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Config
Before
After
CHANGELOG.md entry:
[new-rule-option]
allow-single-line-comments
forfile-header
rule