Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPRESS] Cannot include svg icons as a .svg extension when adding inline to twig templates [fix exists] #65

Open
aCyborg opened this issue Feb 22, 2017 · 2 comments

Comments

@aCyborg
Copy link
Contributor

aCyborg commented Feb 22, 2017

Bill fixed this on FAMSF and here is a link to that commit: https://github.com/palantirnet/famsf-digital-stories/pull/100/commits/0650e596aea82beb536cf920424c49ee5647bf2e

I think we should apply this to all butlers, not just famsf's

@aCyborg aCyborg changed the title Cannot include svg icons as a .svg extension [fix exists] [SPRESS] Cannot include svg icons as a .svg extension [fix exists] Feb 22, 2017
@biz123
Copy link
Contributor

biz123 commented Feb 22, 2017

For some context, in the styleguide we had been saving .svg files as .html files to include them in Spress, because at first it seemed Spress did not support svg includes. The problem was to add them in Drupal we had to include them as .svg, so every svg in the styleguide had to be resaved for Drupal and that got cumbersome as SVGs have been getting redesigned while we have been developing in Drupal.

The fix was simply to add svg to the text_extensions in the config.yml for Spress. I also had to keep the styleguide svg folder inside src/includes and symlink that to our Drupal theme.

@aCyborg aCyborg closed this as completed Mar 1, 2017
@biz123 biz123 reopened this Mar 1, 2017
@biz123
Copy link
Contributor

biz123 commented Mar 1, 2017

Watching SVGs is not the complete fix @patrickfweston. We also need .svg in the list of text extensions. I now see this issue doesn't clearly say we need to be able to add inline SVGs to twig templates by including as .svg.

We need this change for that:
https://github.com/palantirnet/famsf-digital-stories/blob/0650e596aea82beb536cf920424c49ee5647bf2e/styleguide/config.yml#L14

...where svg is included so they can be added to the markup.

@biz123 biz123 changed the title [SPRESS] Cannot include svg icons as a .svg extension [fix exists] [SPRESS] Cannot include svg icons as a .svg extension when adding inline to twig templates [fix exists] Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants