[SPRESS] Make sure SVGs can be included #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @patrickfweston ! How would you recommend I test this update? Thanks! |
aCyborg
approved these changes
Mar 8, 2017
|
@MichellanneLi : Great call. I forgot to include testing instructions. They're up now! |
|
@patrickfweston works great! Thanks so much for your work on butler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #65
As outlined, if one tries to include an SVG in one's Twig file, nothing is printed. This pull request adds SVGs to the
text_extensionsvariable to ensure they can be included.To test:
The quickest, easiest way to test this is to update you config.yml file to reflect the changes as made by this PR.
Alternatively, you can update you styleguide/package.json file and change (around line 15) the Butler dependency to point to the following hash:
207ef881d0aff81b6ce2935bbd3258055eb51e5b. Then, you'll have to npm install again per the README's instructions for ButlerEither way, once you get the changes: