Fixes npm packages.json #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds js hint to npm
|
Could you change the homepage url to this repo? |
|
@MichellanneLi Can you address Arthur's comment? |
|
@mathewpeterson I'd be happy to, but could you please walk me through it? I haven't had the opportunity to work with Git since our meeting on Tuesday. Let me know when would be convenient for you. |
|
https://github.com/palantirnet/butler/pull/10/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R12 Should this be updated as well? |
| @@ -16,5 +16,24 @@ | |||
| "bugs": { | |||
| "url": "https://github.com/labyrwa/fed-automation/issues" | |||
There was a problem hiding this comment.
Should this line be updated as well?
|
Hi @mathewpeterson, I made the requested changes for your review. Thanks! |
|
@labbydev Do these changes look OK? I would like to merge. |
|
@mathewpeterson these look good to me. I love to see progress here!! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds js hint to npm