-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor tweaks to current documentation based on setup work #26
Conversation
|
||
## Add Butler to a project | ||
1. If the project does not already have npm dependencies run `npm init` to create a `package.json` file | ||
|
||
1. Add Butler as a dependency by running `npm install --save palantirnet/butler` | ||
|
||
When Butler is installing it will ask for the GitHub repository for your project. Please provide the HTTPS link for the project repository. | ||
Example: `https://github.com/palantirnet/[project].git` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it require the .git? On mcor we didn't include the .git part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you didn't use the .git
part on MCOR I would say that it doesn't require it. This is the example that I use in the prompt for it though.
Added some information around Sculpin environment config |
|
||
## Making Changes to Butler | ||
|
||
Please feel free to change/extend/break this Gulpfile to fit the specific needs of the project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is one thing I'm not sure about. Since the Butler Gulpfile isn't checked into the project, how would one change/extend/break it for the project?
Potential answers:
- Create branches and PRs in the Butler repo
- Copy the Gulpfile to... somewhere in your project... and update the
scripts
in your project'spackages.json
file
@labbydev ok I made a bunch of edits... I have one question about something in the README, which I think I just commented on. |
@becw I have updated the Making Changes section, but I'm also tempted to delete the section entirely. There's nothing there that isn't covered in other documentation, and I wonder if that section is truly necessary. Thoughts? |
Yes, I would be down with that. |
0948059
to
19646ed
Compare
@labbydev !! The snippet in my last commit means you don't need global gulp to run Butler!!
|
@becw is there any way that we can create a way to automate the adding scripts part? |
@becw judging by the silence I feel that it would be best to just merge this as is for now, thoughts? |
Confirm that the notes and instructions in the README reflect an accurate setup workflow.