Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor tweaks to current documentation based on setup work #26

Merged
merged 6 commits into from
Apr 27, 2016

Conversation

labbydev
Copy link
Contributor

@labbydev labbydev commented Apr 14, 2016

Confirm that the notes and instructions in the README reflect an accurate setup workflow.


## Add Butler to a project
1. If the project does not already have npm dependencies run `npm init` to create a `package.json` file

1. Add Butler as a dependency by running `npm install --save palantirnet/butler`

When Butler is installing it will ask for the GitHub repository for your project. Please provide the HTTPS link for the project repository.
Example: `https://github.com/palantirnet/[project].git`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it require the .git? On mcor we didn't include the .git part

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you didn't use the .git part on MCOR I would say that it doesn't require it. This is the example that I use in the prompt for it though.

@labbydev
Copy link
Contributor Author

Added some information around Sculpin environment config

@becw becw assigned becw and unassigned aCyborg Apr 15, 2016

## Making Changes to Butler

Please feel free to change/extend/break this Gulpfile to fit the specific needs of the project.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one thing I'm not sure about. Since the Butler Gulpfile isn't checked into the project, how would one change/extend/break it for the project?

Potential answers:

  • Create branches and PRs in the Butler repo
  • Copy the Gulpfile to... somewhere in your project... and update the scripts in your project's packages.json file

@becw
Copy link
Member

becw commented Apr 15, 2016

@labbydev ok I made a bunch of edits... I have one question about something in the README, which I think I just commented on.

@becw becw assigned labbydev and unassigned becw Apr 15, 2016
@labbydev
Copy link
Contributor Author

@becw I have updated the Making Changes section, but I'm also tempted to delete the section entirely. There's nothing there that isn't covered in other documentation, and I wonder if that section is truly necessary. Thoughts?

@labbydev labbydev assigned becw and unassigned labbydev Apr 15, 2016
@becw
Copy link
Member

becw commented Apr 15, 2016

Yes, I would be down with that.

@becw becw assigned aCyborg and unassigned becw Apr 15, 2016
@becw
Copy link
Member

becw commented Apr 15, 2016

@aCyborg I'm assigning this to you for review since both @labbydev and I have worked on it ;)

@becw becw force-pushed the documentation-refinement branch from 0948059 to 19646ed Compare April 15, 2016 23:29
@becw
Copy link
Member

becw commented Apr 16, 2016

@labbydev !! The snippet in my last commit means you don't need global gulp to run Butler!!

  "scripts": {
    "butler": "node_modules/butler/node_modules/.bin/gulp --gulpfile node_modules/butler/Gulpfile.js",
    "develop": "node_modules/butler/node_modules/.bin/gulp --gulpfile node_modules/butler/Gulpfile.js develop",
    "linting": "node_modules/butler/node_modules/.bin/gulp --gulpfile node_modules/butler/Gulpfile.js test",
    "deploy": "node_modules/butler/node_modules/.bin/gulp --gulpfile node_modules/butler/Gulpfile.js deploy"
  },

@labbydev
Copy link
Contributor Author

@becw is there any way that we can create a way to automate the adding scripts part?

@aCyborg
Copy link
Contributor

aCyborg commented Apr 20, 2016

this PR looks good, except that last comment by @labbydev directed towards @becw is unresolved. Im reassigning to bec to see if that can be resolved before I merge.

@aCyborg aCyborg assigned becw and unassigned aCyborg Apr 20, 2016
@labbydev
Copy link
Contributor Author

@becw judging by the silence I feel that it would be best to just merge this as is for now, thoughts?

@labbydev labbydev merged commit 87fdde1 into master Apr 27, 2016
@labbydev labbydev deleted the documentation-refinement branch April 27, 2016 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants