Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill process running on :8000 to remove error. #32

Merged
merged 1 commit into from
May 23, 2016

Conversation

nstriedinger
Copy link
Contributor

events.js:154
throw er; // Unhandled 'error' event
^
Error: Command failed: ../../vendor/bin/sculpin generate --watch --server --project-dir="../../styleguide/"

[React\Socket\ConnectionException]
*Could not bind to tcp://0.0.0.0:8000: Address already in use *

generate [--watch] [--server] [--url URL] [--port PORT]

at ChildProcess.exithandler (child_process.js:202:12)
at emitTwo (events.js:100:13)
at ChildProcess.emit (events.js:185:7)
at maybeClose (internal/child_process.js:850:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:215:5)

@aCyborg
Copy link
Contributor

aCyborg commented May 19, 2016

ah yes I need this! I can test I think.

@aCyborg
Copy link
Contributor

aCyborg commented May 19, 2016

So this works and fixes the bug (afaict).

I had the error, and I pulled in the branch and re ran which fixed it.

Then I recreated the error, and a few times and re ran to double check.

I, however, do not want to merge since I don't really understand the code you wrote aside from generally. Someone should take a closer look at that for code understandings.

(but this does fix the bug!)

@aCyborg
Copy link
Contributor

aCyborg commented May 19, 2016

Note: New Pnet is currently running on this branch so update that when this is merged (or tell me to).

@labbydev
Copy link
Contributor

@nstriedinger @aCyborg the code looks good to me. Should we be concerned about killing whatever is already going on on port 8000?

@aCyborg
Copy link
Contributor

aCyborg commented May 23, 2016

@labbydev @nstriedinger Not that I can think of. The only thing I ever have up there is sculpin. What issues are you thinking of?

@labbydev
Copy link
Contributor

I'm not really thinking of any @aCyborg I just didn't know if there was a reason that we should be concerned with it.

@labbydev labbydev merged commit 65daac4 into master May 23, 2016
@labbydev labbydev deleted the nstriedinger-patch-1 branch May 23, 2016 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants