Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sass to run before spress-serve #74

Merged
merged 1 commit into from
Apr 21, 2017
Merged

add sass to run before spress-serve #74

merged 1 commit into from
Apr 21, 2017

Conversation

biz123
Copy link
Contributor

@biz123 biz123 commented Apr 5, 2017

This issue that I found easy to observe when running on my VM is that the latest css was not getting compiled when initially running Butler. I would sometimes either need to run butler twice or make some arbitrary sass change to trigger Butler to run.

To test:

Use this branch on a project by updating the packages.js to say "butler": "github:palantirnet/butler#run-sass-initially" on the butler dependancies line, and make sure you have deleted node_modules and the build directory as well as all compiled css in your project.

Go to the styleguide folder in the VM and run npm install.

Once that is done, test the two scenarios:

run `npm run butler' and make sure build is created with the current css.

stop butler and delete the build file, make a change to Sass, then run butler again and make sure the new css is compiled in the build.

@biz123 biz123 requested a review from aCyborg April 5, 2017 21:12
@labbydev
Copy link
Contributor

This looks good to me

@labbydev labbydev merged commit 2b725cc into master Apr 21, 2017
@MichellanneLi MichellanneLi deleted the run-sass-initially branch January 4, 2018 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants