add sass to run before spress-serve #74
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue that I found easy to observe when running on my VM is that the latest css was not getting compiled when initially running Butler. I would sometimes either need to run butler twice or make some arbitrary sass change to trigger Butler to run.
To test:
Use this branch on a project by updating the packages.js to say
"butler": "github:palantirnet/butler#run-sass-initially"
on the butler dependancies line, and make sure you have deleted node_modules and the build directory as well as all compiled css in your project.Go to the styleguide folder in the VM and run npm install.
Once that is done, test the two scenarios:
run `npm run butler' and make sure build is created with the current css.
stop butler and delete the build file, make a change to Sass, then run butler again and make sure the new css is compiled in the build.