Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creates npm-shrinkwrap.json #88

Closed
wants to merge 1 commit into from
Closed

Creates npm-shrinkwrap.json #88

wants to merge 1 commit into from

Conversation

MichellanneLi
Copy link
Contributor

This pr updates the shrinkwrap in order to make the asap package available.

@MichellanneLi MichellanneLi requested review from becw and labbydev August 1, 2017 22:23
@becw
Copy link
Member

becw commented Aug 1, 2017

I don't think that running npm shrinkwrap did what we expected here -- the shrinkwrap file is now pretty much empty. What I expected is that it would have some updated version numbers in it.

@becw
Copy link
Member

becw commented Oct 19, 2017

This is replaced by PR #90.

@becw becw closed this Oct 19, 2017
@becw becw deleted the fixes-asap-package branch October 19, 2017 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@becw becw Awaiting requested review from becw

@labbydev labbydev Awaiting requested review from labbydev

Assignees

@labbydev labbydev

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichellanneLi @becw @labbydev