feat: add rector rule for deprecated GDToolkit resource methods and p…

…roperties in 10.2
palantirnet · Jan 24, 2024 · a7bcc4a · a7bcc4a
1 parent 4a2e739
commit a7bcc4a
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 1 deletion.
diff --git a/config/drupal-10/drupal-10.2-deprecations.php b/config/drupal-10/drupal-10.2-deprecations.php
@@ -3,12 +3,27 @@
 declare(strict_types=1);
 
 use DrupalRector\Rector\Deprecation\FunctionToStaticRector;
+use DrupalRector\Rector\Deprecation\MethodToMethodWithCheckRector;
 use DrupalRector\Rector\ValueObject\FunctionToStaticConfiguration;
+use DrupalRector\Rector\ValueObject\MethodToMethodWithCheckConfiguration;
 use Rector\Config\RectorConfig;
+use Rector\Renaming\Rector\PropertyFetch\RenamePropertyRector;
+use Rector\Renaming\ValueObject\RenameProperty;
 
-return static function (RectorConfig $rectorConfig): void {
+return static function(RectorConfig $rectorConfig): void {
     // https://www.drupal.org/node/2999981
     $rectorConfig->ruleWithConfiguration(FunctionToStaticRector::class, [
         new FunctionToStaticConfiguration('10.2.0', 'format_size', '\Drupal\Core\StringTranslation\ByteSizeMarkup', 'create'),
     ]);
+
+    // https://www.drupal.org/node/3265963
+    $rectorConfig->ruleWithConfiguration(MethodToMethodWithCheckRector::class, [
+        new MethodToMethodWithCheckConfiguration('Drupal\system\Plugin\ImageToolkit\GDToolkit', 'getResource', 'getImage'),
+        new MethodToMethodWithCheckConfiguration('Drupal\system\Plugin\ImageToolkit\GDToolkit', 'setResource', 'setImage'),
+    ]);
+
+    // https://www.drupal.org/node/3265963
+    $rectorConfig->ruleWithConfiguration(RenamePropertyRector::class, [
+        new RenameProperty('Drupal\system\Plugin\ImageToolkit\GDToolkit', 'resource', 'image')
+    ]);
 };
diff --git a/tests/src/Rector/Deprecation/MethodToMethodWithCheckRector/config/configured_rule.php b/tests/src/Rector/Deprecation/MethodToMethodWithCheckRector/config/configured_rule.php
@@ -6,10 +6,13 @@
 use DrupalRector\Rector\ValueObject\MethodToMethodWithCheckConfiguration;
 use DrupalRector\Tests\Rector\Deprecation\DeprecationBase;
 use Rector\Config\RectorConfig;
+use Rector\Renaming\Rector\ClassConstFetch\RenameClassConstFetchRector;
 
 return static function (RectorConfig $rectorConfig): void {
     DeprecationBase::addClass(MethodToMethodWithCheckRector::class, $rectorConfig, true, [
         new MethodToMethodWithCheckConfiguration('Drupal\Core\Session\MetadataBag', 'clearCsrfTokenSeed', 'stampNew'),
         new MethodToMethodWithCheckConfiguration('Drupal\Core\Entity\EntityInterface', 'urlInfo', 'toUrl'),
+        new MethodToMethodWithCheckConfiguration('Drupal\system\Plugin\ImageToolkit\GDToolkit', 'getResource', 'getImage'),
+        new MethodToMethodWithCheckConfiguration('Drupal\system\Plugin\ImageToolkit\GDToolkit', 'setResource', 'setImage'),
     ]);
 };
diff --git a/tests/src/Rector/Deprecation/MethodToMethodWithCheckRector/fixture/basic.php.inc b/tests/src/Rector/Deprecation/MethodToMethodWithCheckRector/fixture/basic.php.inc
@@ -7,6 +7,10 @@ function simple_example() {
     /** @var \Drupal\Core\Entity\EntityInterface $untranslated_entity */
     $untranslated_entity = \Drupal::entityTypeManager()->getStorage('node')->load(123);
     $form_state->setRedirectUrl($untranslated_entity->urlInfo('canonical'));
+
+    $toolkit = new \Drupal\system\Plugin\ImageToolkit\GDToolkit;
+    $toolkit->getResource();
+    $toolkit->setResource();
 }
 ?>
 -----
@@ -19,5 +23,9 @@ function simple_example() {
     /** @var \Drupal\Core\Entity\EntityInterface $untranslated_entity */
     $untranslated_entity = \Drupal::entityTypeManager()->getStorage('node')->load(123);
     $form_state->setRedirectUrl($untranslated_entity->toUrl('canonical'));
+
+    $toolkit = new \Drupal\system\Plugin\ImageToolkit\GDToolkit;
+    $toolkit->getImage();
+    $toolkit->setImage();
 }
 ?>