Merge pull request #278 from palantirnet/feature/9.3-FILE_STATUS_PERM…

…ANENT New rector (9.3): Support FILE_STATUS_PERMANENT deprecation
palantirnet · Dec 27, 2023 · f12360f · f12360f
2 parents 8910e6d + c13c401
commit f12360f
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 0 deletions.
diff --git a/config/drupal-9/drupal-9.3-deprecations.php b/config/drupal-9/drupal-9.3-deprecations.php
@@ -2,6 +2,7 @@
 
 declare(strict_types=1);
 
+use DrupalRector\Drupal8\Rector\ValueObject\ConstantToClassConfiguration;
 use DrupalRector\Drupal9\Rector\Deprecation\ExtensionPathRector;
 use DrupalRector\Drupal9\Rector\Deprecation\FileBuildUriRector;
 use DrupalRector\Drupal9\Rector\Deprecation\FunctionToEntityTypeStorageMethod;
@@ -66,4 +67,11 @@
         new FunctionToFirstArgMethodConfiguration('taxonomy_term_uri', 'toUrl'),
         new FunctionToFirstArgMethodConfiguration('taxonomy_term_title', 'label'),
     ]);
+
+    // Change record: https://www.drupal.org/node/3022147
+    new ConstantToClassConfiguration(
+        'FILE_STATUS_PERMANENT',
+        'Drupal\file\FileInterface',
+        'STATUS_PERMANENT',
+    );
 };
diff --git a/...s/src/Drupal8/Rector/Deprecation/ConstantToClassConstantRector/config/configured_rule.php b/...s/src/Drupal8/Rector/Deprecation/ConstantToClassConstantRector/config/configured_rule.php
@@ -15,4 +15,11 @@
             'STORAGE_TIMEZONE',
         ),
     ]);
+    DeprecationBase::addClass(ConstantToClassConstantRector::class, $rectorConfig, false, [
+        new ConstantToClassConfiguration(
+            'FILE_STATUS_PERMANENT',
+            'Drupal\file\FileInterface',
+            'STATUS_PERMANENT',
+        ),
+    ]);
 };
diff --git a/tests/src/Drupal8/Rector/Deprecation/ConstantToClassConstantRector/fixture/fixture.php.inc b/tests/src/Drupal8/Rector/Deprecation/ConstantToClassConstantRector/fixture/fixture.php.inc
@@ -2,20 +2,42 @@
 
 function simple_example() {
     $timezone = DATETIME_STORAGE_TIMEZONE;
+
+    $file_status = FILE_STATUS_PERMANENT;
 }
 
 function as_an_argument() {
     $timezone = new \DateTimeZone(DATETIME_STORAGE_TIMEZONE);
+
+    $class = new \TestClass(FILE_STATUS_PERMANENT);
 }
+
+class ClassDefault {
+    public function test($status = FILE_STATUS_PERMANENT) {
+        return true;
+    }
+}
+
 ?>
 -----
 <?php
 
 function simple_example() {
     $timezone = \Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::STORAGE_TIMEZONE;
+
+    $file_status = \Drupal\file\FileInterface::STATUS_PERMANENT;
 }
 
 function as_an_argument() {
     $timezone = new \DateTimeZone(\Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::STORAGE_TIMEZONE);
+
+    $class = new \TestClass(\Drupal\file\FileInterface::STATUS_PERMANENT);
 }
+
+class ClassDefault {
+    public function test($status = \Drupal\file\FileInterface::STATUS_PERMANENT) {
+        return true;
+    }
+}
+
 ?>