Upgrade to Rector 0.8 #122
Conversation
There was a problem hiding this comment.
Thanks so much, Tomas!
We were looking into these updates a bit ago and this is going to help us a lot in upgrading to the new system.
I left some comments on some things that we'll want to add in before merging.
I think with the number of changes, it's probably easier for me to make a fork of your branch and work on those and then merge it in. Does that sounds like a good approach to you?
We may get a chance to work on this later in the week.
Thanks again.
| @@ -10,7 +10,9 @@ | |||
| "ast" | |||
| ], | |||
| "require": { | |||
| "rector/rector-prefixed": "0.7.29" | |||
| "php": "^7.2", | |||
| "jawira/case-converter": "^1.1", | |||
There was a problem hiding this comment.
This was removed since we weren't using it any more. We'll have to remove it here as well.
There was a problem hiding this comment.
Sure, go for it.
I think I messed rebase, that's why it's here
| @@ -1,5 +0,0 @@ | |||
| # Contains automatic fixes for some deprecations introduced in Drupal 8.4. | |||
There was a problem hiding this comment.
Does this one have a .php version?
There was a problem hiding this comment.
I might have missed that, during rebase or my for to your master.
Could you add it?
| use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator; | ||
|
|
||
| return static function (ContainerConfigurator $containerConfigurator): void { | ||
| $containerConfigurator->import(__DIR__ . '/vendor/palantirnet/drupal-rector/config/drupal-8/drupal-8-all-deprecations.yml'); |
There was a problem hiding this comment.
Does this need to be updated from .yml to .php?
I think we'll want to also add commented out lines for the individual files in case people want to pick and choose.
There was a problem hiding this comment.
Yes, if it's a Rector config.
| $parameters = $containerConfigurator->parameters(); | ||
|
|
||
| $parameters->set(Option::AUTOLOAD_PATHS, ['docroot/core', 'docroot/core/modules', 'docroot/modules', 'docroot/profiles']); | ||
| $parameters->set(Option::EXCLUDE_PATHS, ['*/upgrade_status/tests/modules/*']); |
There was a problem hiding this comment.
We'll want to add another commented out line here for people to exclude the test folders.
| use Rector\Core\Configuration\Option; | ||
| use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator; | ||
|
|
||
| return static function (ContainerConfigurator $containerConfigurator): void { |
There was a problem hiding this comment.
Overall, we'll want to add back the comments to help people customize this file.
Looking at the comments, I agree with you. Go for it! I'll save my energy for Rector BC breaks ;) |
|
@damontgomery Btw, this might be interesting to you to prevent similar "upgrade" PRs in the future: rectorphp/rector#4222 |
|
Sorry for the late reply. Other things came up and I wanted to apologize and provide an update. Not sure when we / I will be able to have a look at this. It's at the top of our list of TODOs. |
Hi folks,
in recent 2 months there've been many changes in Rector, like moving from YAML to PHP.
I was thinking it might you save you some troubles, if I'd handle the upgrade myself, as I made those BC breaks you'd hate to fix 😄
So here it is