Update README.md #141
Merged
Update README.md #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A couple of typos
|
Thanks, @ccampos . There is a major PR to move to a newer version of Rector (#134) and that will probably cause a merge conflict with this. I'm not sure the best path forward to avoid rework / merge conflicts between the two. Maybe I can ping you if that is updated and you can make another PR to get credit? I can also try to figure out how to make a commit as you at that time, but I haven't done that before. Thanks again. |
|
I think this can be merged without causing conflicts. This is an easier merge, I don't mind rebasing #134 and fixing any conflicts that arise, @damontgomery |
mglaman
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of typos