Issue #3277704: Remove PHPUNIT_75 constant in Rector #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mglaman
requested changes
May 3, 2022
| @@ -11,7 +11,6 @@ | |||
|
|
|||
| $containerConfigurator->import(PHPUnitSetList::PHPUNIT_60); | |||
| $containerConfigurator->import(PHPUnitSetList::PHPUNIT_70); | |||
| $containerConfigurator->import(PHPUnitSetList::PHPUNIT_75); | |||
There was a problem hiding this comment.
What is the replacement? We need this as it fixes PHPUnit code for folks.
There was a problem hiding this comment.
Answering for myself:
There is no replacement value. Removed in rector/rector-phpunit:0.11.26 due to it being a complex upgrade path.
|
We can work on this once #195 lands and is green. This was removed in a patch release without deprecation. |
|
If this was rebased against |
FlorentTorregrosa
force-pushed
the
3277704
branch
from
2f63bba to
2a90a6a
Compare
|
Hi, Thanks @mglaman for your review. PR rebased |
mglaman
approved these changes
May 23, 2022
|
Thanks for the merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove usage of non-existing constant in rector 0.12.22
Drupal.org issue
https://www.drupal.org/project/rector/issues/3277704