-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add $defaultTheme property if missing on BrowserTestBase #211
Add $defaultTheme property if missing on BrowserTestBase #211
Conversation
It's running, but not making changes:
And here:
|
@mglaman This one has a merge conflict I am uncertain about |
# Conflicts: # config/drupal-8/drupal-8.8-deprecations.php
…stuff to get working. Also fixed tests and how they run. Fixed codestyle
0acf398
to
0f70eb0
Compare
This was one of the top issues last bot run. So thought I'd update and fix it. All seems fine now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve of the changes 👍 but it's my own PR so, this is my +1 for someone to approve and merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per matt, approved
Description
Add
protected $defaultTheme = 'stark';
to functional tests if missing.This could cause test failures because they assume on markup for Classy, which
the theme should be changed to
starterkit
as Classy is going away in Drupal 10.To Test
Drupal.org issue
https://www.drupal.org/project/rector/issues/3299835