Remove dependency on rector-src #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etup-ddev > We have moved here: > https://github.com/ddev/github-action-setup-ddev > Please update your usages: > uses: ddev/github-action-setup-ddev@v1
mglaman
requested changes
Aug 8, 2023
mglaman
approved these changes
Aug 8, 2023
|
This should supersede #234 correct? |
|
Yeah that's the proper thing to do. |
agentrickard
approved these changes
Aug 16, 2023
bbrala
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No more rector-src, YAY, life just got easier. I also added a way to pin rector and phpstan easily through a script.
The only conflict here was phpstan which broke rector running. With some other changes all is fine and we have a stable main again.