WIP: Rule to convert action to attributes#257

Merged

agentrickard merged 27 commits intopalantirnet:mainfrom skilld-labs:action-attributes

Mar 8, 2024

+693-4

Commits on Mar 8, 2024

WIP: Rule to convert action to attributes

andypost
authored and
bbrala
committed
Rebase on main and move rector to Drupal10 namespace
bbrala
committed
Add basic unit test for ActionAnnotationToAttributeRector.
bbrala
committed
Fix codestyle
bbrala
committed
Fix namespace in config for ActionAnnotationToAttributeRector
bbrala
committed
The label should be "action_label",
bbrala
committed
Fix phpstan
bbrala
committed
Add test for other possible translation attribute arguments
bbrala
committed
Add test for situation where the attribute already exists
bbrala
committed
If action attribute is already present, do not add it again.
bbrala
committed
ActionAnnotationToAttributeRector now also parses extra @translate arguments.
bbrala
committed
Fix code-style
bbrala
committed
Refactor some methods in AbstractDrupalCoreRector
bbrala
committed
Fix some logic in AbstractDrupalCoreRector so its more readable (and return types match the method names).
bbrala
committed
Introduce DrupalIntroducedAndRemovalVersionConfiguration and refactor ActionAnnotationToAttributeRector to use AbstractDrupalCoreRector (mostly)
bbrala
committed
Add tests for BC path and update default tests to expect no BC path
bbrala
committed
Fix convertTranslateAnnotation early return. Also simplify a little by taking the actual annotation instead of its container.
bbrala
committed
Fix style
bbrala
committed
Remove prefixed class from use statements.
bbrala
committed
Allow rule to be configured so we can use it on multiple rules. Rename configuration to more targetted.
bbrala
committed
Rename fixtures to add plugin id
bbrala
committed
Add block test and configuration
bbrala
committed
Add missing deriver key
bbrala
committed
Use built in AnnotationToAttribute mapper for forms value in Block annotation
bbrala
committed
Fix codestyle
bbrala
committed
Fully remove annotations from drupal 10 set for now until we have better validation on these.
bbrala
committed
Protected to public
bbrala
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Rule to convert action to attributes#257

Commits on Mar 8, 2024

WIP: Rule to convert action to attributes

Rebase on main and move rector to Drupal10 namespace

Add basic unit test for ActionAnnotationToAttributeRector.

Fix codestyle

Fix namespace in config for ActionAnnotationToAttributeRector

The label should be "action_label",

Fix phpstan

Add test for other possible translation attribute arguments

Add test for situation where the attribute already exists

If action attribute is already present, do not add it again.

ActionAnnotationToAttributeRector now also parses extra @translate arguments.

Fix code-style

Refactor some methods in AbstractDrupalCoreRector

Fix some logic in AbstractDrupalCoreRector so its more readable (and return types match the method names).

Introduce DrupalIntroducedAndRemovalVersionConfiguration and refactor ActionAnnotationToAttributeRector to use AbstractDrupalCoreRector (mostly)

Add tests for BC path and update default tests to expect no BC path

Fix convertTranslateAnnotation early return. Also simplify a little by taking the actual annotation instead of its container.

Fix style

Remove prefixed class from use statements.

Allow rule to be configured so we can use it on multiple rules. Rename configuration to more targetted.

Rename fixtures to add plugin id

Add block test and configuration

Add missing deriver key

Use built in AnnotationToAttribute mapper for forms value in Block annotation

Fix codestyle

Fully remove annotations from drupal 10 set for now until we have better validation on these.

Protected to public