Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPUnit: Rector to fix missing parent::setUp and parent::tearDown methods #273

Merged
merged 7 commits into from
Nov 27, 2023

Conversation

bbrala
Copy link
Collaborator

@bbrala bbrala commented Nov 25, 2023

Description

Based on this phpstan rule: phpstan/phpstan-phpunit@d686c82

Adds parent::setUp and parent::tearDown to those methods when missing.

To Test

Run tests

@bbrala bbrala force-pushed the feature/phpunit-setup-teardown branch from 4beb1e5 to 4ada8d0 Compare November 25, 2023 16:04
Copy link
Contributor

@agentrickard agentrickard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean. Makes sense.

@bbrala bbrala merged commit 5dde476 into main Nov 27, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants