Fix EntityManagerRector based on project_analysis results #274
Conversation
|
Fixes 220 error while running analysis. Search for In https://git.drupalcode.org/project/project_analysis/-/commits/11-55227?ref_type=tags |
|
Marked draft, needs better solution. |
|
Copied a functional test locally, which shows the difference. Will push tonight. |
|
Ok, only error i made was mostly the removal of the depth counter. Also made phpstan a little more happy. Ready for review. Should solve lots of errors in project anlysis |
bbrala
force-pushed
the
bug/entitymanagerrector
branch
from
0c9acfb to
bb3284c
Compare
bbrala
force-pushed
the
bug/entitymanagerrector
branch
from
bb3284c to
5a2340f
Compare
| // Should the expression be the class we are looking for and the name is the one we are looking for, we can return early. | ||
| if ($node instanceof $class && $this->getName($node->name) === $name) { | ||
| if ($node instanceof Node && $node instanceof $class && $this->getName($node->name) === $name) { |
There was a problem hiding this comment.
expr is nullable? It's not supposed to be
| $node = $node->var; | ||
| ++$depth; | ||
| if ($node instanceof $class && $this->getName($node->name)) { | ||
|
|
||
| if ($node instanceof Node && $node instanceof $class && isset($node->name) && $this->getName($node->name)) { |
There was a problem hiding this comment.
again, feels weird that we have to instanceof something which shouldn't be nullable and is \PhpParser\Node\Expr
And we can call $this->getName($node), that's what the name resolver is for.
| while (isset($node->var) && !($node->var instanceof $class && $this->getName($node->var->name) !== $name)) { | ||
| while (isset($node->var) && !($node->var instanceof $class && isset($node->var->name) && $this->getName($node->var->name) !== $name)) { |
There was a problem hiding this comment.
Would this work if we did $this->getName($node->var)? See \Rector\NodeNameResolver\NodeNameResolver\VariableNameResolver::resolve
There was a problem hiding this comment.
I tried this, it makes the functional tests fail :(
|
|
||
| public function provideConfigFilePath(): string | ||
| { | ||
| // must be implemented |
| use Rector\Config\RectorConfig; | ||
|
|
||
| return static function (RectorConfig $rectorConfig): void { | ||
| // $rectorConfig->rule(EntityViewRector::class); |
|
I tried to use getName properly, but couldnt get unit and functional tests to work :( (small tip: |
bbrala
changed the title
Description
Explain the technical implementation of the work done.
To Test
Drupal.org issue
Provide a link to the issue from https://www.drupal.org/project/rector/issues. If no issue exists, please create one and link to this PR.