Hotfix: New rector FILE_STATUS_PERMANENT was not added to deprecation list. … #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Only config object was intialized.
| @@ -61,7 +61,7 @@ class DBRector extends AbstractRector implements ConfigurableRectorInterface | |||
| private array $configuration; | |||
|
|
|||
| /** | |||
| * @var \DrupalRector\Services\AddCommentService | |||
| * @var AddCommentService | |||
There was a problem hiding this comment.
My understanding is that @var descriptions should use the full class path, so I don't understand these changes.
There was a problem hiding this comment.
This is part of the Symfony code standards. https://cs.symfony.com/doc/rules/import/fully_qualified_strict_types.html
agentrickard
approved these changes
Dec 28, 2023
| @@ -61,7 +61,7 @@ class DBRector extends AbstractRector implements ConfigurableRectorInterface | |||
| private array $configuration; | |||
|
|
|||
| /** | |||
| * @var \DrupalRector\Services\AddCommentService | |||
| * @var AddCommentService | |||
There was a problem hiding this comment.
This is part of the Symfony code standards. https://cs.symfony.com/doc/rules/import/fully_qualified_strict_types.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Only config object was intialized.
Description
Explain the technical implementation of the work done.
To Test
Drupal.org issue
Provide a link to the issue from https://www.drupal.org/project/rector/issues. If no issue exists, please create one and link to this PR.