feat: Optimize AnnotationToAttributeRector #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew \Drupal\Core\StringTranslation\TranslatableMarkup
|
Also this was used here to generate a MR: https://www.drupal.org/project/drupal/issues/3396166 |
mglaman
approved these changes
Mar 9, 2024
docs/core_plugin_conversion.md
Outdated
Comment on lines
28
to
33
| $rectorConfig->autoloadPaths([ | ||
| './lib', | ||
| './modules', | ||
| './profiles', | ||
| './themes' | ||
| ]); |
There was a problem hiding this comment.
These settings and you're in core but the script execution looks like it's from the directory above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add some better handling of types using Doctrine annotation service. Also add test for ContentEntityType and ConfigEntityType annotation. This seems like it will handle most things in core (with support for BC fixes for contrib).
Also added documentation for core plugin conversion so it can be started to be used.
Lets get this merged :)
To Test
Drupal.org issue
https://www.drupal.org/project/rector/issues/3265946