New rector (10.1): drupal_theme_rebuild is deprecated #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbrala
force-pushed
the
feature/drupal_theme_rebuild
branch
from
9f08e62 to
14e2355
Compare
There was a problem hiding this comment.
This all looks fine. I am curious about the php-cs-fixer error.
Might that be a PHP version issue? https://www.drupal.org/project/rector/issues/3427029
|
See also #300 |
bbrala
force-pushed
the
feature/drupal_theme_rebuild
branch
from
b0ecfd5 to
1d10b36
Compare
bbrala
force-pushed
the
feature/drupal_theme_rebuild
branch
from
1d10b36 to
213cdde
Compare
agentrickard
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rector for drupal_theme_rebuild. Also refactor FunctionToServiceRector to allow BC patched.
See: mglaman/drupal-change-record-triage#435
To Test
Drupal.org issue
https://www.drupal.org/project/rector/issues/3427029