Draft Add HookConvert

.github/workflows/functional_test__single_rectors.yml

@@ -0,0 +1,75 @@
+
+name: functional_test_single
+
+# This test will run on every pull request, and on every commit on any branch
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+  schedule:
+    # Run tests every week (to check for rector changes)
+    - cron:  '0 0 * * 0'
+
+jobs:
+    run_functional_test_single:
+        name: Functional Test | single rectors
+        runs-on: ubuntu-latest
+        steps:
+            -   uses: actions/checkout@v3
+            -   uses: shivammathur/setup-php@v2
+                with:
+                    php-version: "${{ matrix.php-version }}"
+                    coverage: none
+                    tools: composer:v2
+                    extensions: dom, curl, libxml, mbstring, zip, pdo, mysql, pdo_mysql, gd
+            -   name: Setup Drupal
+                uses: bluehorndigital/[email protected]
+                with:
+                    version: '^11.0'
+                    path: ~/drupal
+            -   name: Install Drupal Rector
+                run: |
+                    cd ~/drupal
+                    composer require palantirnet/drupal-rector:@dev --no-progress
+            -   name: Prepare rector_examples folder in the drupal modules directory
+                run: |
+                    cd ~/drupal
+                    mkdir -p web/modules/custom
+                    cp -R vendor/palantirnet/drupal-rector/tests/functional/hookconvertrector/fixture/hookconvertrector web/modules/custom/hookconvertrector
+            # dry-run is expected to return exit code 2 if there are changes, which we are expecting to happen, here.
+            # an error code of 1 represents other errors.
+            # @see \Rector\Core\Console\ExitCode::CHANGED_CODE
+            -   name: Run rector against Drupal (dry-run)
+                run: |
+                    cd ~/drupal
+                    for d in web/modules/custom/*; do
+                        if [ -d "$d" ]; then
+                            echo "Processing $d"
+                            cp vendor/palantirnet/drupal-rector/tests/functional/$(basename ${d})/rector.php .
+                            vendor/bin/rector process $d -vvv --dry-run --debug || if (($? == 2)); then true; else exit 1; fi
+                        fi
+                    done
+            -   name: Run rector against Drupal
+                run: |
+                    cd ~/drupal
+                    for d in web/modules/custom/*; do
+                        if [ -d "$d" ]; then
+                            echo "Processing $d"
+                            cp vendor/palantirnet/drupal-rector/tests/functional/$(basename ${d})/rector.php .
+                            vendor/bin/rector process $d --debug
+                        fi
+                    done
+            # diff options:
+            # -r: recursive
+            # -u: show the joined context, like git diff
+            # -b: ignore whitespace
+            # -B: ignore lines that are only whitespace
+            -   name: Check that the updated examples match expectations
+                run: |
+                    cd ~/drupal
+                    for d in web/modules/custom/*; do
+                        if [ -d "$d" ]; then
+                            diff -rubB "$d" "vendor/palantirnet/drupal-rector/tests/functional/$(basename ${d})/fixture/$(basename ${d})_updated"
+                        fi
+                    done

.php-cs-fixer.dist.php

@@ -6,6 +6,9 @@
         __DIR__.'/tests',
         __DIR__.'/config/drupal-*',
     ])
+    ->exclude([
+        'functional/hookconvertrector/fixture',
+    ])
 ;
 
 return (new PhpCsFixer\Config())

src/Drupal8/Rector/Deprecation/DBRector.php

@@ -56,7 +56,7 @@ class DBRector extends AbstractRector implements ConfigurableRectorInterface
     protected $optionsArgumentPosition;
 
     /**
-     * @var \DrupalRector\Drupal8\Rector\ValueObject\DBConfiguration[]
+     * @var DBConfiguration[]
      */
     private array $configuration;
 

src/Drupal8/Rector/Deprecation/DrupalServiceRenameRector.php

@@ -14,7 +14,7 @@
 class DrupalServiceRenameRector extends AbstractRector implements ConfigurableRectorInterface
 {
     /**
-     * @var \DrupalRector\Drupal8\Rector\ValueObject\DrupalServiceRenameConfiguration[]
+     * @var DrupalServiceRenameConfiguration[]
      */
     protected array $staticArgumentRenameConfigs = [];
 

src/Drupal8/Rector/Deprecation/EntityLoadRector.php

@@ -27,7 +27,7 @@
 final class EntityLoadRector extends AbstractRector implements ConfigurableRectorInterface
 {
     /**
-     * @var \DrupalRector\Drupal8\Rector\ValueObject\EntityLoadConfiguration[]
+     * @var EntityLoadConfiguration[]
      */
     protected array $entityTypes;
 

src/Drupal9/Rector/Deprecation/ExtensionPathRector.php

@@ -15,7 +15,7 @@
 class ExtensionPathRector extends AbstractRector implements ConfigurableRectorInterface
 {
     /**
-     * @var \DrupalRector\Drupal9\Rector\ValueObject\ExtensionPathConfiguration[]
+     * @var ExtensionPathConfiguration[]
      */
     private array $configuration;
 

src/Drupal9/Rector/Deprecation/UiHelperTraitDrupalPostFormRector.php

@@ -48,7 +48,7 @@ public function getNodeTypes(): array
      *
      * @throws ShouldNotHappenException
      *
-     * @return array<int, ?\PhpParser\Node\Arg>
+     * @return array<int, ?Node\Arg>
      */
     private function safeArgDestructure(Node\Expr\MethodCall $node): array
     {

src/Rector/AbstractDrupalCoreRector.php

@@ -16,7 +16,7 @@
 abstract class AbstractDrupalCoreRector extends AbstractRector implements ConfigurableRectorInterface
 {
     /**
-     * @var array|\DrupalRector\Contract\VersionedConfigurationInterface[]
+     * @var array|VersionedConfigurationInterface[]
      */
     protected array $configuration = [];