Feature/remove deprecations

phpstan-baseline.neon

@@ -147,35 +147,3 @@ parameters:
 			message: "#^Call to an undefined method PHPStan\\\\Type\\\\Type\\:\\:getValue\\(\\)\\.$#"
 			count: 1
 			path: src/Drupal9/Rector/Deprecation/ExtensionPathRector.php
-
-		-
-			message: """
-				#^Fetching deprecated class constant REMOVE_NODE of class PhpParser\\\\NodeTraverser\\:
-				Use NodeVisitor\\:\\:REMOVE_NODE instead\\.$#
-			"""
-			count: 1
-			path: src/Drupal9/Rector/Deprecation/PassRector.php
-
-		-
-			message: """
-				#^Class DrupalRector\\\\Set\\\\Drupal10SetList implements deprecated interface Rector\\\\Set\\\\Contract\\\\SetListInterface\\:
-				This interface needs a reflection to load and uses constant links\\. Now we changed to services provider architecture that can be used and registerd easily\\. Use$#
-			"""
-			count: 1
-			path: src/Set/Drupal10SetList.php
-
-		-
-			message: """
-				#^Class DrupalRector\\\\Set\\\\Drupal8SetList implements deprecated interface Rector\\\\Set\\\\Contract\\\\SetListInterface\\:
-				This interface needs a reflection to load and uses constant links\\. Now we changed to services provider architecture that can be used and registerd easily\\. Use$#
-			"""
-			count: 1
-			path: src/Set/Drupal8SetList.php
-
-		-
-			message: """
-				#^Class DrupalRector\\\\Set\\\\Drupal9SetList implements deprecated interface Rector\\\\Set\\\\Contract\\\\SetListInterface\\:
-				This interface needs a reflection to load and uses constant links\\. Now we changed to services provider architecture that can be used and registerd easily\\. Use$#
-			"""
-			count: 1
-			path: src/Set/Drupal9SetList.php

src/Drupal8/Rector/Deprecation/DBRector.php

@@ -56,7 +56,7 @@ class DBRector extends AbstractRector implements ConfigurableRectorInterface
     protected $optionsArgumentPosition;
 
     /**
-     * @var \DrupalRector\Drupal8\Rector\ValueObject\DBConfiguration[]
+     * @var DBConfiguration[]
      */
     private array $configuration;
 

src/Drupal8/Rector/Deprecation/DrupalServiceRenameRector.php

@@ -14,7 +14,7 @@
 class DrupalServiceRenameRector extends AbstractRector implements ConfigurableRectorInterface
 {
     /**
-     * @var \DrupalRector\Drupal8\Rector\ValueObject\DrupalServiceRenameConfiguration[]
+     * @var DrupalServiceRenameConfiguration[]
      */
     protected array $staticArgumentRenameConfigs = [];
 

src/Drupal8/Rector/Deprecation/EntityLoadRector.php

@@ -27,7 +27,7 @@
 final class EntityLoadRector extends AbstractRector implements ConfigurableRectorInterface
 {
     /**
-     * @var \DrupalRector\Drupal8\Rector\ValueObject\EntityLoadConfiguration[]
+     * @var EntityLoadConfiguration[]
      */
     protected array $entityTypes;
 

src/Drupal9/Rector/Deprecation/ExtensionPathRector.php

@@ -15,7 +15,7 @@
 class ExtensionPathRector extends AbstractRector implements ConfigurableRectorInterface
 {
     /**
-     * @var \DrupalRector\Drupal9\Rector\ValueObject\ExtensionPathConfiguration[]
+     * @var ExtensionPathConfiguration[]
      */
     private array $configuration;
 

src/Drupal9/Rector/Deprecation/PassRector.php

@@ -7,6 +7,7 @@
 use DrupalRector\Utility\GetDeclaringSourceTrait;
 use PhpParser\Node;
 use PhpParser\NodeTraverser;
+use PhpParser\NodeVisitor;
 use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@@ -51,7 +52,12 @@ public function refactor(Node $node)
         }
 
         if ($this->getDeclaringSource($node->expr) === 'Drupal\KernelTests\AssertLegacyTrait') {
-            return NodeTraverser::REMOVE_NODE;
+            if (defined('\PhpParser\NodeVisitor::REMOVE_NODE')) {
+                return NodeVisitor::REMOVE_NODE;
+            } else {
+                /* @phpstan-ignore-next-line */
+                return NodeTraverser::REMOVE_NODE;
+            }
         }
 
         return $node;

src/Drupal9/Rector/Deprecation/UiHelperTraitDrupalPostFormRector.php

@@ -48,7 +48,7 @@ public function getNodeTypes(): array
      *
      * @throws ShouldNotHappenException
      *
-     * @return array<int, ?\PhpParser\Node\Arg>
+     * @return array<int, ?Node\Arg>
      */
     private function safeArgDestructure(Node\Expr\MethodCall $node): array
     {

src/Rector/AbstractDrupalCoreRector.php

@@ -16,7 +16,7 @@
 abstract class AbstractDrupalCoreRector extends AbstractRector implements ConfigurableRectorInterface
 {
     /**
-     * @var array|\DrupalRector\Contract\VersionedConfigurationInterface[]
+     * @var array|VersionedConfigurationInterface[]
      */
     protected array $configuration = [];
 

src/Set/Drupal10SetList.php

@@ -4,9 +4,7 @@
 
 namespace DrupalRector\Set;
 
-use Rector\Set\Contract\SetListInterface;
-
-final class Drupal10SetList implements SetListInterface
+final class Drupal10SetList
 {
     public const DRUPAL_10 = __DIR__.'/../../config/drupal-10/drupal-10-all-deprecations.php';
     public const DRUPAL_100 = __DIR__.'/../../config/drupal-10/drupal-10.0-deprecations.php';

src/Set/Drupal8SetList.php

@@ -4,9 +4,7 @@
 
 namespace DrupalRector\Set;
 
-use Rector\Set\Contract\SetListInterface;
-
-final class Drupal8SetList implements SetListInterface
+final class Drupal8SetList
 {
     public const DRUPAL_8 = __DIR__.'/../../config/drupal-8/drupal-8-all-deprecations.php';
     public const DRUPAL_80 = __DIR__.'/../../config/drupal-8/drupal-8.0-deprecations.php';

src/Set/Drupal9SetList.php

@@ -4,9 +4,7 @@
 
 namespace DrupalRector\Set;
 
-use Rector\Set\Contract\SetListInterface;
-
-final class Drupal9SetList implements SetListInterface
+final class Drupal9SetList
 {
     public const DRUPAL_9 = __DIR__.'/../../config/drupal-9/drupal-9-all-deprecations.php';
     public const DRUPAL_90 = __DIR__.'/../../config/drupal-9/drupal-9.0-deprecations.php';