Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8.8 fine tuning #101

Merged
merged 5 commits into from
Dec 5, 2019
Merged

8.8 fine tuning #101

merged 5 commits into from
Dec 5, 2019

Conversation

shaal
Copy link
Contributor

@shaal shaal commented Dec 4, 2019 •
edited
Loading

Description

Based on Drupal core's new composer template, I updated composer.json to follow a similar structure.

Testing instructions

  1. composer install

Remaining tasks

  • After the-build PR gets merged with the new version of coder, update composer.json here to use the-build's new release version instead of using the-build special temporary branch.

@shaal shaal requested a review from becw December 4, 2019 17:32
@shaal shaal self-assigned this Dec 4, 2019
@shaal shaal mentioned this pull request Dec 4, 2019
Merged
becw
becw reviewed Dec 4, 2019
View reviewed changes
composer.json Outdated Show resolved Hide resolved
becw
becw reviewed Dec 4, 2019
View reviewed changes
composer.json Outdated Show resolved Hide resolved
becw
becw reviewed Dec 4, 2019
View reviewed changes
composer.json Outdated Show resolved Hide resolved
becw
becw reviewed Dec 4, 2019
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@becw
Copy link
Member

becw commented Dec 4, 2019

I have a couple comments, but otherwise this seems like mostly reordering the composer.json file, which is fine!

@becw
Copy link
Member

becw commented Dec 4, 2019

@shaal I cut the-build:2.2.1 with the drupal/coder update: https://github.com/palantirnet/the-build/releases/tag/2.2.1

@shaal shaal requested a review from becw December 5, 2019 17:40
@shaal
Copy link
Contributor Author

shaal commented Dec 5, 2019

@becw I removed coder, core-project-message, and updated to latest the-build in composer.json

@becw becw merged commit 38cac07 into develop Dec 5, 2019
@becw becw deleted the 8.8-fine-tuning branch December 5, 2019 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@becw becw becw approved these changes

Assignees

@shaal shaal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaal @becw